[PATCH] D99509: [RISCV] Add legality check for vectoring reduction

[Luke via Phabricator via llvm-commits]

luke957 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.h:153
+      return true;
+    // FIXME: Case FMin and FMax return true when they are supported by the backend.
+    case RecurKind::FMin:
----------------
craig.topper wrote:
> Please wrap this to 80 columns.
Fixed.


================
Comment at: llvm/test/Transforms/LoopVectorize/RISCV/scalable-reductions.ll:354
+
+; Note: This test was added to ensure we always check the legality of reductions (end emit a warning if necessary) before checking for memory dependencies
+; CHECK-REMARK: Scalable vectorization not supported for the reduction operations found in this loop. Using fixed-width vectorization instead.
----------------
craig.topper wrote:
> "end emit a warning" -> "and emit a warning"?
Fix typo. Remove fmin and fmax test cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99509/new/

https://reviews.llvm.org/D99509