[PATCH] D98405: [cmake] Link to libnetwork on Haiku in llvm-jitlink

[Niels Sascha Reedijk via Phabricator via llvm-commits]

nielx added a comment.

In D98405#2673557 <https://reviews.llvm.org/D98405#2673557>, @serge-sans-paille wrote:

> You may need to do the same change in llvm/tools/llvm-jitlink/CMakeLists.txt, which makes me think it may valuable to implement a decent check à la autoconf to check for the actual symbol you're looking for, probably based on a sequence of CHECK_LIBRARY_EXISTS. Would you be ok to do that change?

Thank you for having a look at the patch, I appreciate it!

Not sure whether I fully understand you, but I made the change both in `llvm/tools/llvm-jitlink/CMakeLists.txt` and `llvm/tools/llvm-jitlink/llvm-jitlink-executor/CMakeLists.txt`, is there another place that links to the network symbols?

About making it more generic, I would be okay looking into that, but I am slightly doubtful of the added value. The Haiku ABI is stable, and there is no version in existence that has these symbols in another place. I therefore don't know what the added value would be of doing a dynamic check for something that's by definition static.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98405/new/

https://reviews.llvm.org/D98405