[PATCH] D100085: [X86] Support -march=rocketlake

[Freddy, Ye via Phabricator via llvm-commits]

FreddyYe added a comment.

Hi @MaskRay, I tried to refactor, but met some difficulties. Since these defines are dictionary ordered, a new #define may insert into a common CHECK. So it is difficult to let different RUN share common CHECKs.

  // RUN: %clang -march=pentium-mmx -m32 -E -dM %s -o - 2>&1 \
  // RUN:     -target i386-unknown-linux \
  // RUN:   | FileCheck -match-full-lines %s -check-prefixes=CHECK_I386_M32,CHECK_I586_M32,CHECK_PENTIUM_MMX_M32
  
  // CHECK_I386_M32: #define __i386 1
  // CHECK_I386_M32: #define __i386__ 1
  // CHECK_I386_M32: #define i386 1
  
  // CHECK_I586_M32: #define __i586 1
  // CHECK_I586_M32: #define __i586__ 1
  // CHECK_I586_M32: #define __pentium 1
  // CHECK_I586_M32: #define __pentium__ 1
  // CHECK_I586_M32: #define __tune_i586__ 1
  // CHECK_I586_M32: #define __tune_pentium__ 1
  
  // CHECK_PENTIUM_MMX_M32: #define __MMX__ 1
  // CHECK_PENTIUM_MMX_M32: #define __pentium_mmx__ 1
  // CHECK_PENTIUM_MMX_M32: #define __tune_pentium_mmx__ 1

The example above will destroy the original order of the define list. Do you have some good suggestions?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100085/new/

https://reviews.llvm.org/D100085