[PATCH] D100002: [CSSPGO] Move pseudo probes to the beginning of a block to unblock SelectionDAG combine.
Wenlei He via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 7 21:03:21 PDT 2021
wenlei added inline comments.
================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:8001
+ // Remove redundant pseudo probes.
+ MadeChange |= removeRedundantPseudoProbes(&Block);
+ // Move the rest probes to the beginning of the block.
----------------
For dbg values, redundancy removal and placement are separate. Do we want to follow that?
Since removeRedundantPseudoProbes is part of RemoveRedundantDbgInstrs already, how critical is this extra removal?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100002/new/
https://reviews.llvm.org/D100002
More information about the llvm-commits
mailing list