[PATCH] D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057)

Ta-Wei Tu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 7 20:50:29 PDT 2021


TaWeiTu added a comment.

In D97828#2674875 <https://reviews.llvm.org/D97828#2674875>, @Whitney wrote:

> @TaWeiTu How do you want to handle the `lcssa.ll` failure? Maybe we can only disallow memory accesses that are guarded by loop variant condition?

Now only loop-variant-guarded blocks are considered "bad". `lcssa.ll` should be fixed.
We should probably also add logic to check whether the orders of memory accesses actually change after interchanging the loop, but I think it's beyond the scope of this patch and can be improved in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97828/new/

https://reviews.llvm.org/D97828



More information about the llvm-commits mailing list