[PATCH] D100014: [GreedyRA ORE] Add function level spill/reloads stats
    Philip Reames via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Apr  7 20:26:44 PDT 2021
    
    
  
reames accepted this revision.
reames added a comment.
In D100014#2673174 <https://reviews.llvm.org/D100014#2673174>, @skatkov wrote:
> In D100014#2673150 <https://reviews.llvm.org/D100014#2673150>, @thegameg wrote:
>
>> This looks good too, thanks! Please add a test or extend the ones in llvm/test/CodeGen/AArch64/arm64-spill-remarks.ll.
>
> Sure, I plan to upload all patches for reviewers to see the end point and then will add tests...
Meta: Please don't do this.  Each patch should stand on it's own with the tests which are needed to motivate this patch.
Also LGTM contingent on a test being added before landing.
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100014/new/
https://reviews.llvm.org/D100014
    
    
More information about the llvm-commits
mailing list