[PATCH] D100076: [lld-macho] Support -add_ast_path

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/SyntheticSections.cpp:683
 void SymtabSection::emitStabs() {
+  for (const std::string &s : config->astPaths) {
+    StabsEntry astStab(N_AST);
----------------
clayborg wrote:
> I don't think we can have more than one N_AST values emitted. Does ld64 supports multiple?
ld64 does support multiple. Do you think we should emit just one value regardless?


================
Comment at: lld/MachO/SyntheticSections.cpp:685
+    StabsEntry astStab(N_AST);
+    astStab.strx = stringTableSection.addString(s);
+    stabs.emplace_back(std::move(astStab));
----------------
clayborg wrote:
> Does ld64 put the mod time of the AST file in the symbol table value? I can't remember, but it would be worth checking
It doesn't. (`add-ast-path.s` passes as-is if `ld` is substituted for `%lld`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100076/new/

https://reviews.llvm.org/D100076