[PATCH] D100079: [Attributor] Don't modify functions outside of the current SCC

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 7 18:33:55 PDT 2021


jdoerfert added a comment.

In D100079#2675525 <https://reviews.llvm.org/D100079#2675525>, @aeubanks wrote:

> I'm not actually sure that this is the right change, it was more of a "does something like this make sense"
>
> Updating the tests, this is doing something wrong since it's replacing a bunch of values with undef. We'd probably need to look at all of the callers to see if they're doing the right thing.

I don't follow, sorry.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100079/new/

https://reviews.llvm.org/D100079



More information about the llvm-commits mailing list