[PATCH] D100002: [CSSPGO] Move pseudo probes to the beginning of a block to unblock SelectionDAG combine.

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 7 17:35:32 PDT 2021


hoy added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:8004-8005
+    auto FirstInst = Block.getFirstInsertionPt();
+    while (FirstInst != Block.end() && FirstInst->isDebugOrPseudoInst())
+      ++FirstInst;
+    BasicBlock::iterator I(FirstInst);
----------------
wmi wrote:
> Why pseudo probes need to be put after debug instructions on the top, is it necessary? 
Probes are not necessary to be after debug instructions, but thought it would be nice to keep existing probes that are in the beginning of the block in order. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100002/new/

https://reviews.llvm.org/D100002



More information about the llvm-commits mailing list