[PATCH] D100079: [Attributor] Don't modify functions outside of the current SCC

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

Thanks a lot for tracking this down!

LGTM, two nits though: can we include the reproducer as test please, and below.



================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:1346
 
+  bool canChangeUse(Use &U) {
+    if (Functions.empty())
----------------
Can you add a doxygen comment here describing when/why we sometimes cannot change a use.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100079/new/

https://reviews.llvm.org/D100079