[PATCH] D64831: [Xtensa 5/10] Add Xtensa MCTargetDescr initial functionality.

[Andrei Safronov via Phabricator via llvm-commits]

andreisfr added inline comments.


================
Comment at: llvm/lib/Target/Xtensa/MCTargetDesc/XtensaAsmBackend.cpp:90
+    } else {
+      llvm_unreachable("Big-endian mode currently is not supported!");
+    }
----------------
craig.topper wrote:
> This should maybe be a report_fatal_error? llvm_unreachable will be optimized out of release builds so if this is something a user can trigger the fatal error would be better.
I substituted llvm_unreachable to report_fatal_error everywhere, in other patches also


================
Comment at: llvm/lib/Target/Xtensa/MCTargetDesc/XtensaMCCodeEmitter.cpp:15
+
+#define DEBUG_TYPE "mccodeemitter"
+#include "MCTargetDesc/XtensaMCTargetDesc.h"
----------------
craig.topper wrote:
> I think this typically comes after the includes
Corrected


================
Comment at: llvm/lib/Target/Xtensa/MCTargetDesc/XtensaMCCodeEmitter.cpp:86
+    // TODO Big-endian insertion of Size bytes.
+    llvm_unreachable("Big-endian mode currently is not supported!");
+  }
----------------
craig.topper wrote:
> maybe fatal_error?
Corrected


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64831/new/

https://reviews.llvm.org/D64831