[PATCH] D99865: [RFC, AMDGPU, test] Fix use of undef FileCheck var

Wed Apr 7 15:02:58 PDT 2021

arsenm added a comment.

In D99865#2675219 <https://reviews.llvm.org/D99865#2675219>, @thopre wrote:

> In D99865#2675176 <https://reviews.llvm.org/D99865#2675176>, @arsenm wrote:
>
>> It's really hard to write checks for R600, but it's in maintenance mode. The comment doesn't really make sense to me. I doubt this check was ever really correct or stable. You can't really write this test stably and expect specific things in T registers at a specific time. I guess just go with this is it passes?
>
> Unfortunately the test case as updated by this diff FAILs, as can be seen above. Unfortunately the current testcase only succeeds due to a bug in FileCheck which I have a patch for. FileCheck currently count an undefined variable as a match failure which makes a CHECK-NOT with an undefined variable succeed. Does the comment make sense with the old CHECKS (see https://reviews.llvm.org/rG880a80ad07b6ea7ead3a842fc03c74c2247c9486)?
>
> Should we remove those checks altogether?

Might as well delete them then. I don't know how you can really write a reasonable check for what the comment describes

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99865/new/

https://reviews.llvm.org/D99865