[PATCH] D99900: [llvm] [testsuite] Fix invalid DW_AT_location DWARF expression in unattached-global.ll
Jan Kratochvil via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 7 13:21:21 PDT 2021
jankratochvil added a comment.
In D99900#2672711 <https://reviews.llvm.org/D99900#2672711>, @dblaikie wrote:
> @aprantl @JDevlieghere do you folks want to update the verifier in any way to make this sort of thing invalid?
Before implementing it into `DWARFExpression::verify` I see two issues:
- IIUC the verifier would be run by `llvm-dwarfdump --verify` which is currently not being run.
- The goal of this testcase is to omit `DW_AT_location` when producing the binary. Therefore the invalid DWARF expression would not be written out at all. So it could not be verified as incorrect by `llvm-dwarfdump`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99900/new/
https://reviews.llvm.org/D99900
More information about the llvm-commits
mailing list