[PATCH] D99709: [DebugInfo] Avoid generating DW_TAG_GNU_call_site if no DW_TAG_GNU_call_site_parameter present

Wed Apr 7 12:28:22 PDT 2021

dblaikie added a comment.

In D99709#2673316 <https://reviews.llvm.org/D99709#2673316>, @djtodoro wrote:

> In D99709#2671762 <https://reviews.llvm.org/D99709#2671762>, @dblaikie wrote:
>
>> In D99709#2663321 <https://reviews.llvm.org/D99709#2663321>, @djtodoro wrote:
>>
>>> I think some LLDB tests would fail for sure...
>>
>> Is there LLVM test coverage for this? If not it'd be good to make sure some is added.
>
> There are (the premerge also shows it). By applying this patch we have:
>
>   Failed Tests:
>   LLVM :: CodeGen/X86/xray-custom-log.ll
>   LLVM :: DebugInfo/AArch64/unretained-declaration-subprogram.ll
>   LLVM :: DebugInfo/MIR/ARM/call-site-info-vmovd.mir
>   LLVM :: DebugInfo/MIR/ARM/call-site-info-vmovs.mir
>   LLVM :: DebugInfo/MIR/Hexagon/bundled-call-pr44001.mir
>   LLVM :: DebugInfo/MIR/X86/call-site-gnu-vs-dwarf5-attrs.mir
>   LLVM :: DebugInfo/MIR/X86/debug-call-site-param.mir
>   LLVM :: DebugInfo/X86/convert-loclist.ll
>   LLVM :: DebugInfo/X86/dbg-call-site-undef-params.ll
>   LLVM :: DebugInfo/X86/debug_addr.ll
>   LLVM :: DebugInfo/X86/dwarf-callsite-related-attrs.ll
>   LLVM :: DebugInfo/X86/fission-call-site.ll
>   LLVM :: DebugInfo/X86/lto-cross-cu-call-origin-ref.ll
>   LLVM :: DebugInfo/X86/ranges_always.ll
>   LLVM :: tools/llvm-dwarfdump/X86/stats-dbg-callsite-info.ll

Ah, great!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99709/new/

https://reviews.llvm.org/D99709