[PATCH] D99933: [Debug-Info] Use inlined strings in .dwinfo section by default for DBX.

Wed Apr 7 12:27:45 PDT 2021

dblaikie added inline comments.

================
Comment at: llvm/test/DebugInfo/XCOFF/dbx-inlinedstrings.ll:32-33
+
+; CHECK-NOT: DW_FORM_strp
+; CHECK: DW_FORM_string
----------------
Esme wrote:
> dblaikie wrote:
> > I'd probably put these CHECK lines up the top near the RUN line - and flesh them out a bit, maybe? Oh, and in the RUN line, run llc to an object, run the object through llvm-dwarfdump rather than checking the assembly directly. Possibly use implicit-check-not DW_FORM_strp, and explicitly check where the DW_FORM_string turns up (perhaps dump debug_info in verbose mode, and check, for instance that the DW_AT_producer is in the right form and has the right value)
> > 
> > (do you have a pointer to the testing that was originally added for this feature when it was introduced for NVPTX? Might be worth comparing it/seeing if there's some inspiration there)
> The feature for NVPTX introduced in D41827 is not the main purpose in that patch, so the whole assembly was checked directly there.
fair enough - thanks for the test update, it's probably a bit overkill here. Testing just the DW_AT_producer, for instance, seems like it'd be good enough to demonstrate the use of FORM_string and the value. No need to test a bunch of other (especially non-string) attributes (that sort of testing can make the test brittle - if we add new attributes, reorder attributes, etc, this test would need to be updated despite the functionality it intends to test not having changed)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99933/new/

https://reviews.llvm.org/D99933