[llvm] 9895285 - [RISCV] Replace 'return ReplaceNode' with 'ReplaceNode; return;' NFC

[Craig Topper via llvm-commits]

Author: Craig Topper
Date: 2021-04-07T12:18:41-07:00
New Revision: 98952851911624918c9bb7309dd8030a73f8ef76

URL: https://github.com/llvm/llvm-project/commit/98952851911624918c9bb7309dd8030a73f8ef76
DIFF: https://github.com/llvm/llvm-project/commit/98952851911624918c9bb7309dd8030a73f8ef76.diff

LOG: [RISCV] Replace 'return ReplaceNode' with 'ReplaceNode; return;' NFC

ReplaceNode is a void function as is the function that we were
doing this in. While this is valid code, it was a bit confusing.

Added: 
    

Modified: 
    llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp b/llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp
index 57de6ceeef40..e20a7c3c6777 100644
--- a/llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp
+++ b/llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp
@@ -411,7 +411,6 @@ void RISCVDAGToDAGISel::Select(SDNode *Node) {
     }
     ReplaceNode(Node, selectImm(CurDAG, DL, ConstNode->getSExtValue(), XLenVT));
     return;
-    break;
   }
   case ISD::FrameIndex: {
     SDValue Imm = CurDAG->getTargetConstant(0, DL, XLenVT);
@@ -925,11 +924,13 @@ void RISCVDAGToDAGISel::Select(SDNode *Node) {
       SDValue RC = CurDAG->getTargetConstant(InRegClassID, DL, XLenVT);
       SDNode *NewNode = CurDAG->getMachineNode(TargetOpcode::COPY_TO_REGCLASS,
                                                DL, VT, SubV, RC);
-      return ReplaceNode(Node, NewNode);
+      ReplaceNode(Node, NewNode);
+      return;
     }
 
     SDValue Insert = CurDAG->getTargetInsertSubreg(SubRegIdx, DL, VT, V, SubV);
-    return ReplaceNode(Node, Insert.getNode());
+    ReplaceNode(Node, Insert.getNode());
+    return;
   }
   case ISD::EXTRACT_SUBVECTOR: {
     SDValue V = Node->getOperand(0);
@@ -968,11 +969,13 @@ void RISCVDAGToDAGISel::Select(SDNode *Node) {
       SDValue RC = CurDAG->getTargetConstant(InRegClassID, DL, XLenVT);
       SDNode *NewNode =
           CurDAG->getMachineNode(TargetOpcode::COPY_TO_REGCLASS, DL, VT, V, RC);
-      return ReplaceNode(Node, NewNode);
+      ReplaceNode(Node, NewNode);
+      return;
     }
 
     SDValue Extract = CurDAG->getTargetExtractSubreg(SubRegIdx, DL, VT, V);
-    return ReplaceNode(Node, Extract.getNode());
+    ReplaceNode(Node, Extract.getNode());
+    return;
   }
   }