[PATCH] D90098: [BasicAA] Don't pass through AA metadata (NFCI)

Jeroen Dobbelaere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 7 07:58:53 PDT 2021


jeroen.dobbelaere added a comment.

In D90098#2673996 <https://reviews.llvm.org/D90098#2673996>, @jeroen.dobbelaere wrote:

> In D90098#2673969 <https://reviews.llvm.org/D90098#2673969>, @nikic wrote:
>
>> @jeroen.dobbelaere I'm not sure on the details, but it may be necessary to pass through just the ptr_provenance information with full restrict and include it in the cache key (while omitting all the other metadata).
>
> Yes, that might be a valid path.

On the other hand, a `ptr_provenance` path skips pointer computations. We might need to refactor this code to separate the 'based on' part, so we can first check the ptr_provenance path (if available), and when that is not conclusive,
we can fall back to the original pointers (that also contain GEP information etc).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90098/new/

https://reviews.llvm.org/D90098



More information about the llvm-commits mailing list