[PATCH] D98644: [DebugInfo] Fix incorrect handling of variadic salvaging in Loop Strength Reduce

Wed Apr 7 07:02:24 PDT 2021

jmorse accepted this revision.
jmorse added a comment.
This revision is now accepted and ready to land.

LGTM with a nit, and modulo @markus 's comment.

================
Comment at: llvm/test/Transforms/LoopStrengthReduce/dbg-preserve-2.ll:3-5
+; Test that LSR does not produce invalid debug info when a debug value is
+; salvaged during LSR by adding additional location operands, then becomes
+; undef, and finally recovered by using equal values gathered before LSR.
----------------
Super-nit, but for the future readers, indicating which dbg.value gets salvaged-and-undef'd behind the scenes would really help -- ideally there'd only be one dbg.value in the function, if that's technically possible.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98644/new/

https://reviews.llvm.org/D98644