[PATCH] D100031: [AMDGPU] SIFoldOperands: clean up tryConstantFoldOp

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 7 05:57:14 PDT 2021


foad created this revision.
foad added reviewers: arsenm, rampitec.
Herald added subscribers: kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl.
foad requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

First clean up the strange API of tryConstantFoldOp where it took an
immediate operand value, but no indication of which operand it was the
value for.

Second clean up the loop that calls tryConstantFoldOp so that it does
not have to restart from the beginning every time it folds an
instruction.

This is NFCI but there are some minor changes caused by the order in
which things are folded.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D100031

Files:
  llvm/lib/Target/AMDGPU/SIFoldOperands.cpp
  llvm/test/CodeGen/AMDGPU/GlobalISel/fshr.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100031.335788.patch
Type: text/x-patch
Size: 18044 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210407/d8d22a39/attachment.bin>


More information about the llvm-commits mailing list