[PATCH] D88287: [NARY-REASSOCIATE] Support reassociation of min/max

Wed Apr 7 05:46:31 PDT 2021

ebrevnov added a comment.

In D88287#2672928 <https://reviews.llvm.org/D88287#2672928>, @critson wrote:

> Raising this here as well, as it seems the previous concern I raised with the commit was ignored.

Sorry, I hadn't seen your concern.

> I am seeing this change go into an infinite loop attempting to example an expression, adding more and more .nary postfixes.
> I have reduced the failure to the attached bugpoint.

Looks like you test case has downstream specifics and doesn't work on vanilla llvm. Please make it runnable on upstream llvm.

> llc -march=amdgcn -mcpu=gfx700 < bugpoint-reduced-simplified.ll
> F16169461: bugpoint-reduced-simplified.ll <https://reviews.llvm.org/F16169461>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88287/new/

https://reviews.llvm.org/D88287