[PATCH] D99950: [SLP] Avoid multiple attempts to vectorize CmpInsts.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with one (repeated) minor



================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:7534
     P = nullptr;
-    if (Vectorize(Inst, R)) {
+    if (!isa<CmpInst>(Inst) && Vectorize(Inst, R)) {
       Res = true;
----------------
Mention in comment we don't do this for CmpInst


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:7547
+            if (!isa<PHINode>(I) && !isa<CmpInst>(I) && !R.isDeleted(I) &&
+                I->getParent() == BB)
               Stack.emplace_back(I, Level);
----------------
Mention in comment we don't do this for CmpInst


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99950/new/

https://reviews.llvm.org/D99950