[llvm] 030ac78 - [Orc][examples] Add lit ToolSubst for LLJITWithRemoteDebugging example

Stefan Gränitz via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 7 00:47:42 PDT 2021


Author: Stefan Gränitz
Date: 2021-04-07T09:47:04+02:00
New Revision: 030ac786d4ff3540b414172810f0a92ece3ca81c

URL: https://github.com/llvm/llvm-project/commit/030ac786d4ff3540b414172810f0a92ece3ca81c
DIFF: https://github.com/llvm/llvm-project/commit/030ac786d4ff3540b414172810f0a92ece3ca81c.diff

LOG: [Orc][examples] Add lit ToolSubst for LLJITWithRemoteDebugging example

The test case added in 258f055ed936 was lacking two important details for the test infrastructure. ae217bf1f327 added the executable to LLVM_TEST_DEPENDS in CMake to make sure the exectubale gets built before we run the test suite. This patch adds a ToolSubst for the executable in LIT, which replaces the tool invokation in the RUN line with an absolute path. It makes sure we don't run accidentally run some other tool from the user's PATH. The test works without it in case LLVM's main binary directory happens to be the working directory (which is default apparently). Configurations that don't build the examples ignore failures for this ToolSubst (and won't run the test).

Reviewed By: echristo

Differential Revision: https://reviews.llvm.org/D99931

Added: 
    

Modified: 
    llvm/test/lit.cfg.py

Removed: 
    


################################################################################
diff  --git a/llvm/test/lit.cfg.py b/llvm/test/lit.cfg.py
index 2a1ccc2dcfbd..32793d339500 100644
--- a/llvm/test/lit.cfg.py
+++ b/llvm/test/lit.cfg.py
@@ -177,7 +177,8 @@ def get_asan_rtlib():
     ToolSubst('Kaleidoscope-Ch6', unresolved='ignore'),
     ToolSubst('Kaleidoscope-Ch7', unresolved='ignore'),
     ToolSubst('Kaleidoscope-Ch8', unresolved='ignore'),
-    ToolSubst('LLJITWithThinLTOSummaries', unresolved='ignore')])
+    ToolSubst('LLJITWithThinLTOSummaries', unresolved='ignore'),
+    ToolSubst('LLJITWithRemoteDebugging', unresolved='ignore')])
 
 llvm_config.add_tool_substitutions(tools, config.llvm_tools_dir)
 


        


More information about the llvm-commits mailing list