[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 6 23:24:41 PDT 2021


aeubanks added a comment.

could you clang-format the patch?



================
Comment at: clang/lib/CodeGen/CGException.cpp:1666-1667
+         ++J) {
+      if (isa<llvm::LoadInst>(J)) {
+        auto LI = dyn_cast<llvm::LoadInst>(J);
+        LI->setVolatile(true);
----------------
```
if (auto*LI = dyn_cast<...>(J)) {
  ...
}
```

and ditto below


================
Comment at: llvm/docs/LangRef.rst:12277
+-feh_asynch (aka MSVC -EHa), these two intrinsics are injected to mark _try
+boundary and to prevent from potential exceptions being moved across boundary.
+Any set of operations can then be confined to the region by reading their leaf
----------------
`prevent potential exceptions from being moved...`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80344/new/

https://reviews.llvm.org/D80344



More information about the llvm-commits mailing list