[PATCH] D100021: cmake: Remove unused property on some targets: LLVM_LINK_LIBS

[Tom Stellard via Phabricator via llvm-commits]

tstellar created this revision.
tstellar added a reviewer: serge-sans-paille.
Herald added a subscriber: mgorny.
tstellar requested review of this revision.
Herald added a project: LLVM.

This doesn't appear to be used anywhere.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D100021

Files:
  llvm/cmake/modules/AddLLVM.cmake


Index: llvm/cmake/modules/AddLLVM.cmake
===================================================================
--- llvm/cmake/modules/AddLLVM.cmake
+++ llvm/cmake/modules/AddLLVM.cmake
@@ -494,7 +494,7 @@
     # Add target include directories from the main target.  This makes it
     # possible to call target_include_directories() with ${name} after
     # calling llvm_add_library() and still have it apply to the object library.
-    set_target_properties(obj.${name} PROPERTIES INCLUDE_DIRECTORIES "$<TARGET_PROPERTY:${name},INCLUDE_DIRECTORIES>")
+    set_target_properties(${obj_name} PROPERTIES INCLUDE_DIRECTORIES "$<TARGET_PROPERTY:${name},INCLUDE_DIRECTORIES>")
   endif()
 
   if(ARG_SHARED AND ARG_STATIC)
@@ -636,10 +636,9 @@
     # property has been set to an empty value.
     set_property(TARGET ${name} PROPERTY LLVM_LINK_COMPONENTS ${ARG_LINK_COMPONENTS} ${LLVM_LINK_COMPONENTS})
 
-    # These two properties are internal properties only used to make sure the
+    # This property is an internal property only used to make sure the
     # link step applied in LLVMBuildResolveComponentsLink uses the same
-    # properties as the target_link_libraries call below.
-    set_property(TARGET ${name} PROPERTY LLVM_LINK_LIBS ${ARG_LINK_LIBS})
+    # property as the target_link_libraries call below.
     set_property(TARGET ${name} PROPERTY LLVM_LIBTYPE ${libtype})
   endif()
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100021.335729.patch
Type: text/x-patch
Size: 1393 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210407/01a66d2e/attachment.bin>