[PATCH] D99933: [Debug-Info] Use inlined strings in .dwinfo section by default for DBX.

[ChenZheng via Phabricator via llvm-commits]

shchenz added inline comments.


================
Comment at: llvm/lib/CodeGen/CommandFlags.cpp:417
           clEnumValN(DebuggerKind::LLDB, "lldb", "lldb"),
+          clEnumValN(DebuggerKind::DBX, "dbx", "dbx"),
           clEnumValN(DebuggerKind::SCE, "sce", "SCE targets (e.g. PS4)")));
----------------
Esme wrote:
> Thanks for @shchenz's comments.
> We have added tuning debugger option DBX in D99400, but missed adding it to llc/opt command flags, which is a one-line change, so I also do it in this patch as well. Is it ok?
The change here is for controlling the inlined string for llc. It is not necessary. Normally, when you compile source files by using clang, clang FE will set the debugger type for you. You should already test this, right? 

Wth this change, now you can test the inlined string settings only with llc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99933/new/

https://reviews.llvm.org/D99933