[PATCH] D100016: [GreedyRA ORE] Separate Folder Reloads and Zero Cost Folder Reloads

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 6 22:17:40 PDT 2021


thegameg added inline comments.


================
Comment at: llvm/lib/CodeGen/RegAllocGreedy.cpp:3166
+             llvm::any_of(Accesses, isSpillSlotAccess)) {
+      if (MI.getOpcode() == TargetOpcode::PATCHPOINT ||
+          MI.getOpcode() == TargetOpcode::STACKMAP ||
----------------
I would extract the extra check in a separate function or lambda like `isSpillSlotAccess` above for readability.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100016/new/

https://reviews.llvm.org/D100016



More information about the llvm-commits mailing list