[PATCH] D100012: [GreedyRA ORE] Extract stats in RAGreedyStats struct. NFC.

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 6 21:48:48 PDT 2021


thegameg added a comment.

In D100012#2673146 <https://reviews.llvm.org/D100012#2673146>, @skatkov wrote:

> In D100012#2673142 <https://reviews.llvm.org/D100012#2673142>, @thegameg wrote:
>
>> LGTM. Doesn't seem like there are any tests testing this remark, maybe you can add one if you have something handy?
>
> There are some tests
> ./CodeGen/AArch64/arm64-spill-remarks-treshold-hotness.ll
> ./CodeGen/AArch64/arm64-spill-remarks.ll
>
> I'll probably add something like this.

Looks like I missed that! Should be fine as is then.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100012/new/

https://reviews.llvm.org/D100012



More information about the llvm-commits mailing list