[PATCH] D99561: Support visitor pattern by PointerUnion.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 6 17:47:54 PDT 2021


mehdi_amini added a comment.

Right, if we look at our containers, we also find APIs that don't match exactly the standard (`DenseMap::find_as` or `insert_as` for example, or `SmallVector::pop_back_val`), so yes someone swapping `std::vector` for `SmallVector` may be surprised.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99561/new/

https://reviews.llvm.org/D99561



More information about the llvm-commits mailing list