[PATCH] D99698: [DWARF] Fix crash for DWARFDie::dump.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added subscribers: jhenderson, labath.
dblaikie added a comment.

In D99698#2672788 <https://reviews.llvm.org/D99698#2672788>, @ayermolo wrote:

> In D99698#2669581 <https://reviews.llvm.org/D99698#2669581>, @dblaikie wrote:
>
>> In D99698#2669200 <https://reviews.llvm.org/D99698#2669200>, @ayermolo wrote:
>>
>>> In D99698#2665550 <https://reviews.llvm.org/D99698#2665550>, @dblaikie wrote:
>>>
>>>> Test case?
>>>
>>> I am not sure how to test it.
>>
>> How about a unit test? We have some for the DWARF parser already.
>
> Ah missed it.
> Are those YAML tests manually constructed? I tried obj2yaml

Sorry, I don't know too much about the yaml2obj/obj2yaml stuff - not sure what state it's in @jhenderson and @labath might have more context on the current state.

but there are also pure unit tests that use LLVM APIs to build DWARF and then test that - perhaps one of those would be suitable here?

> and copied just debug parts.
>
> 1. parsing failed
> 2. Syntax is different then what is in the tests.
>   - Name:            .debug_info Type:            SHT_PROGBITS AddressAlign:    0x1 Content:         A6000000040000000000080100000000210086000000000000008F000000700540000000000044000000027005400000000000120000000156D5000000E100000001028C0000000302917CF200000001028C00000000049005400000000000240000000156ED00000001068C00000003029178F600000001068C00000003029170FB0000000106930000000005E900000005040698000000069D00000007A20000000500010000060100




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99698/new/

https://reviews.llvm.org/D99698