[PATCH] D96045: [llvm-dwarfdump][locstats] Unify handling of inlined vars with no loc

Rumeet Dhindsa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 6 16:46:32 PDT 2021


rdhindsa added a comment.

This patch seems to be causing a slowdown while running dwarfdump --statistics. It looks like more than 50% of the time is spent in collectZeroCovInlinedVars function.

In function collectStatsForObjectFile, variable InlinedFnsToBeProcessed is being created outside the for loop. It looks like the inline functions to be processed are appended and processed multiple times. I verified that by moving creation of that variable into the for loop, the slowdown goes away.

Can you please take a look!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96045/new/

https://reviews.llvm.org/D96045



More information about the llvm-commits mailing list