[PATCH] D99651: [Dexter] Implement DexDeclareFile, a new Dexter command
Jeremy Morse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 6 14:54:09 PDT 2021
jmorse requested changes to this revision.
jmorse added a comment.
This revision now requires changes to proceed.
I ended up taking this for a test drive, and found some difficulty when using the LLDB bindings -- `_add_conditional_breakpoint` ends up being passed a PurePath object for the file_, which is then passed to the LLDB bindings, which croak. This is easily fixed by calling `str(file_)` to convert the PurePath object to a string, but this might affect other debugger drivers & need some assertions adding.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99651/new/
https://reviews.llvm.org/D99651
More information about the llvm-commits
mailing list