[PATCH] D96736: [docs] Fix doxygen comments wrongly attached to the llvm namespace

Nicolás Alvarez via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 6 14:47:21 PDT 2021


nicolas17 marked 2 inline comments as done.
nicolas17 added a comment.

I don't have commit access, please push this for me.



================
Comment at: llvm/include/llvm/CodeGen/Passes.h:89
 
-/// MachineDominanaceFrontier - This pass is a machine dominators analysis pass.
+  /// MachineDominanaceFrontier - This pass is a machine dominators analysis pass.
   extern char &MachineDominanceFrontierID;
----------------
mizvekov wrote:
> Since clang-format is complaining this line is too long anyway, I think you could just remove the redundant mention of 'pass'.
We should actually remove the redundant "MachineDominanaceFrontier" from the comment (I just noticed this one isn't even spelled correctly!), but then I would need to do it to the others, and that certainly belongs in a different commit...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96736/new/

https://reviews.llvm.org/D96736



More information about the llvm-commits mailing list