[PATCH] D94619: [SplitEdge] Update SplitCriticalEdge to return a nullptr only when the edge is not critical

Sidharth Baveja via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 6 14:39:56 PDT 2021


sidbav added a comment.



In D94619#2672518 <https://reviews.llvm.org/D94619#2672518>, @lebedev.ri wrote:

> Could use an IR test. Is only CoroFrame.cpp affected?

Decided to use a unit test for this patch since I modified the functionality of SplitCriticalEdge and SplitEdge, and these functions are tested with unit tests.  Used a unit test to be consistent. 
CoroFrame.cpp, and BasicBlockUtils and BreakCriticalEdges are modified as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94619/new/

https://reviews.llvm.org/D94619



More information about the llvm-commits mailing list