[PATCH] D96736: [docs] Fix doxygen comments wrongly attached to the llvm namespace

Matheus Izvekov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 6 11:58:31 PDT 2021


mizvekov added a comment.

In general LGTM, once you address the couple of points I raised, and address the relevant linter issues.



================
Comment at: llvm/include/llvm/ADT/STLExtras.h:93
 
+/// Utilities for detecting if a given trait holds for some set of arguments
+/// 'Args'. For example, the given trait could be used to detect if a given type
----------------
I think you should just update the comment to describe is_detected, instead of talking about 'utilities' in general.


================
Comment at: llvm/include/llvm/CodeGen/Passes.h:89
 
-/// MachineDominanaceFrontier - This pass is a machine dominators analysis pass.
+  /// MachineDominanaceFrontier - This pass is a machine dominators analysis pass.
   extern char &MachineDominanceFrontierID;
----------------
Since clang-format is complaining this line is too long anyway, I think you could just remove the redundant mention of 'pass'.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96736/new/

https://reviews.llvm.org/D96736



More information about the llvm-commits mailing list