[PATCH] D99972: [lld-macho] Fix & refactor symbol size calculations

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 6 10:36:49 PDT 2021


smeenai added a comment.

Unless you think it only makes sense when paired with the rest of this diff, could you split out the renaming of SubsectionMapping to SubsectionMap into its own NFC diff (and probably just commit that directly)? It'd make the rest of this diff easier to read.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99972/new/

https://reviews.llvm.org/D99972



More information about the llvm-commits mailing list