[PATCH] D98537: [M68k] Implement AsmParser

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added a comment.

> I agree about the tests. I think the existing tests should be converted to Motorola syntax too (as that seems to be the canonical format), however, I'd argue that we should do those //after// the assembler & disassembler have landed (in my opinion, fleshing out that functionality is more pressing as it helps us write better tests more easily).

Perfect, I'll start to rewrite the tests in parallel because we also need to solve several issues (e.g. try to get rid of `extract-section` command in the tests) alone the way so I can imagine it takes time.

> The included test covers the broad strokes of the supported syntax so far and should be enough to prevent code rot. As per the older comment it'll still need a fair few (smaller) revisions. In my opinion, it makes the most sense to add more tests as we go through and ensure the AsmParser actually supports everything it should. Perhaps it makes sense to add relevant Bugzilla bugs for the missing functionality as a prerequisite to landing this?

For sure, please do it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98537/new/

https://reviews.llvm.org/D98537