[PATCH] D99961: [SimplifyInst] Use correct type for GEPs with vector indices.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 6 09:51:33 PDT 2021


fhahn added a comment.

In D99961#2671524 <https://reviews.llvm.org/D99961#2671524>, @nikic wrote:

> This looks okay, but I wonder whether we shouldn't be adjusting the getIndexedType() API instead. We have similar code elsewhere, for example in https://github.com/llvm/llvm-project/blob/9c5ebf0358960adf28931569a0c801b56c8008d9/llvm/lib/IR/Constants.cpp#L2415-L2430.

SGTM, I'll look into this as follow-up


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99961/new/

https://reviews.llvm.org/D99961



More information about the llvm-commits mailing list