[PATCH] D99933: [Debug-Info] Use inlined strings in .dwinfo section by default for DBX.

EsmeYi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 6 09:24:15 PDT 2021


Esme added inline comments.


================
Comment at: llvm/lib/CodeGen/CommandFlags.cpp:417
           clEnumValN(DebuggerKind::LLDB, "lldb", "lldb"),
+          clEnumValN(DebuggerKind::DBX, "dbx", "dbx"),
           clEnumValN(DebuggerKind::SCE, "sce", "SCE targets (e.g. PS4)")));
----------------
Thanks for @shchenz's comments.
We have added tuning debugger option DBX in D99400, but missed adding it to llc/opt command flags, which is a one-line change, so I also do it in this patch as well. Is it ok?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99933/new/

https://reviews.llvm.org/D99933



More information about the llvm-commits mailing list