[PATCH] D99434: [TSAN] Honor acquire failure mode on AtomicCAS

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 6 08:52:25 PDT 2021


delcypher added a comment.

@bruno Thanks for the patch. TSan's runtime isn't my specialty so I've added other reviewers.



================
Comment at: compiler-rt/lib/tsan/rtl/tsan_interface_atomic.cpp:433
+  // Honor failure memory order.
+  CHECK(IsLoadOrder(fmo));
+  if (fmo != mo_acquire)
----------------
Is this something user facing code can set? If yes, then we might want to emit a warning rather than crashing the process.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99434/new/

https://reviews.llvm.org/D99434



More information about the llvm-commits mailing list