[PATCH] D99682: [SelectionDAG] Teach SelectionDAG::FoldConstantArithmetic to handle SPLAT_VECTOR
David Sherwood via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 6 07:41:01 PDT 2021
david-arm added a comment.
LGTM! Thanks a lot for making the changes.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:5179
+ // Build a big vector out of the scalar elements we generated.
+ // TODO: If the inputs were fixed length SPLAT_VECTORs, should this return
+ // a SPLAT_VECTOR?
----------------
nit: Perhaps this should be something like:
If one of the inputs is a fixed length SPLAT_VECTOR ...
since at least one input is BUILD_VECTOR?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99682/new/
https://reviews.llvm.org/D99682
More information about the llvm-commits
mailing list