[PATCH] D99581: [test, GVN] Fix use of var defined in CHECK-NOT

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 6 04:26:07 PDT 2021


thopre added a comment.

In D99581#2670661 <https://reviews.llvm.org/D99581#2670661>, @nikic wrote:

> I'd suggest to simply switch these to update_tests_checks.py instead. Or is there some reason this is not possible for these tests?

Sure. I tried to stick to the current way the test work to minimize the size of the patch. update_tests_checks.py generated tests are a lot more effort to review when something change, easy to miss something IMO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99581/new/

https://reviews.llvm.org/D99581



More information about the llvm-commits mailing list