[PATCH] D99931: [Orc][examples] Add lit ToolSubst for LLJITWithRemoteDebugging example

Stefan Gränitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 6 01:54:22 PDT 2021


sgraenitz created this revision.
sgraenitz added reviewers: dblaikie, echristo.
sgraenitz requested review of this revision.
Herald added a project: LLVM.

The test case added in 258f055ed936 <https://reviews.llvm.org/rG258f055ed93661900bc568350e09f467c0950486> was lacking two important details for the test infrastructure. ae217bf1f327 <https://reviews.llvm.org/rGae217bf1f3277b8c14590a130ee5e63cc1664443> added the executable to LLVM_TEST_DEPENDS in CMake to make sure the exectubale gets built before we run the test suite. This patch adds a ToolSubst for the executable in LIT, which replaces the tool invokation in the RUN line with an absolute path. It makes sure we don't run accidentally run some other tool from the user's PATH. The test works without it in case LLVM's main binary directory happens to be the working directory (which is default apparently). Configurations that don't build the examples ignore failures for this ToolSubst (and won't run the test).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99931

Files:
  llvm/test/lit.cfg.py


Index: llvm/test/lit.cfg.py
===================================================================
--- llvm/test/lit.cfg.py
+++ llvm/test/lit.cfg.py
@@ -177,7 +177,8 @@
     ToolSubst('Kaleidoscope-Ch6', unresolved='ignore'),
     ToolSubst('Kaleidoscope-Ch7', unresolved='ignore'),
     ToolSubst('Kaleidoscope-Ch8', unresolved='ignore'),
-    ToolSubst('LLJITWithThinLTOSummaries', unresolved='ignore')])
+    ToolSubst('LLJITWithThinLTOSummaries', unresolved='ignore'),
+    ToolSubst('LLJITWithRemoteDebugging', unresolved='ignore')])
 
 llvm_config.add_tool_substitutions(tools, config.llvm_tools_dir)
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99931.335433.patch
Type: text/x-patch
Size: 606 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210406/8a9d1724/attachment.bin>


More information about the llvm-commits mailing list