[PATCH] D99620: [CMake][Compiler-rt] Compute LLVM_MAIN_SRC_DIR assuming the monorepo layout.

[Petr Hosek via Phabricator via llvm-commits]

phosek accepted this revision.
phosek added a comment.

LGTM (I've tested this together with D99621 <https://reviews.llvm.org/D99621> locally for the Fuchsia build and everything seems to be working).



================
Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:277
+  # CMake cache value.
+  get_compiler_rt_root_source_dir(CRT_SRC_ROOT_PATH)
+  get_filename_component(LLVM_MAIN_SRC_DIR_DEFAULT "${CRT_SRC_ROOT_PATH}/../llvm" ABSOLUTE)
----------------
I'd avoid `CRT` because that can be confused with CRT subproject of compiler-rt: https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/CMakeLists.txt#L20


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99620/new/

https://reviews.llvm.org/D99620