[PATCH] D99812: [PowerPC] [GlobalISel] Implementation of formal arguments lowering in the IRTranslator for the PPC backend

[Kai Luo via Phabricator via llvm-commits]

lkail added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/GISel/PPCCallLowering.h:21
 
+using namespace llvm;
+
----------------
It's not a good idea to `using namespace XXX` in a header file. Quoted from LLVM coding style
> In header files, adding a 'using namespace XXX' directive pollutes the namespace of any source file that #includes the header, creating maintenance issues.


================
Comment at: llvm/lib/Target/PowerPC/GISel/PPCCallLowering.h:39
 };
 } // end namespace llvm
----------------
Please upload full context patch by using `diff -U999999`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99812/new/

https://reviews.llvm.org/D99812