[PATCH] D99907: [dsymutil] Don't emit .debug_pubnames and .debug_pubtypes unless asked for explicitly

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere created this revision.
JDevlieghere added reviewers: friss, clayborg.
Herald added subscribers: dang, steven_wu, hiraditya.
JDevlieghere requested review of this revision.
Herald added a project: LLVM.

Consider the `.debug_pubnames` and `.debug_pubtypes` their own kind of accelerator table and stop emitting them together with the Apple accelerator tables. The only reason we were still emitting both was for (byte-for-byte) compatibility with dsymutil-classic.

- This patch adds a new accelerator table kind "Pub" which can be specified with `--accelerator=Pub`.
- This patch removes the ability to emit both pubnames/types and apple style accelerator tables.
- This patch removes the `--minimize` option and makes this behavior the default. Specifying the flag will result in a warning but won't abort the program.


https://reviews.llvm.org/D99907

Files:
  llvm/include/llvm/DWARFLinker/DWARFLinker.h
  llvm/include/llvm/DWARFLinker/DWARFStreamer.h
  llvm/lib/DWARFLinker/DWARFLinker.cpp
  llvm/lib/DWARFLinker/DWARFStreamer.cpp
  llvm/test/tools/dsymutil/ARM/obfuscated.test
  llvm/test/tools/dsymutil/X86/basic-linking-bundle.test
  llvm/test/tools/dsymutil/X86/basic-linking-x86.test
  llvm/test/tools/dsymutil/X86/basic-lto-dw4-linking-x86.test
  llvm/test/tools/dsymutil/X86/basic-lto-linking-x86.test
  llvm/test/tools/dsymutil/X86/dsym-companion.test
  llvm/test/tools/dsymutil/X86/minimize.test
  llvm/test/tools/dsymutil/X86/update.test
  llvm/test/tools/dsymutil/cmdline.test
  llvm/tools/dsymutil/DwarfLinkerForBinary.cpp
  llvm/tools/dsymutil/LinkUtils.h
  llvm/tools/dsymutil/Options.td
  llvm/tools/dsymutil/dsymutil.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99907.335354.patch
Type: text/x-patch
Size: 22868 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210405/00e4d486/attachment.bin>