[PATCH] D99377: [PowerPC] Add ROP Protection to prologue and epilogue

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 5 16:38:35 PDT 2021


amyk added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/ppc64-rop-protection.ll:135
+;
+; LE-P9-O0-LABEL: caller:
+; LE-P9-O0:       # %bb.0: # %entry
----------------
Since the test file is large, I'm wondering if some of the CHECKs can be combined/maybe we can use some common `check-prefixes` (if that's a good idea)?
For example, it looks like `LE-P9-O0` and `LE-P8-O0` look similar. As well as `BE-P9` and `BE-P8`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99377/new/

https://reviews.llvm.org/D99377



More information about the llvm-commits mailing list