[PATCH] D99870: [PowerPC, test] Fix use of undef FileCheck var

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 5 15:37:53 PDT 2021


thopre added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/ppc-shrink-wrapping.ll:682
 ; Ensure no subsequent uses of callee-save register before end of function
-; CHECK-NOT: {{[a-z]+}} [[CSR]]
+; CHECK-NOT: {{[a-z]+}} {{[0-9]+}}
 ; CHECK: blr
----------------
This CHECK-NOT is way too generic. For instance here it matches `align 4` in the `.p2align 4` assembly. What are PowerPC's CSR?

Even the following (which enforce the first non whitespace to not be a dot and register to have a least 2 digits) fails:

`CHECK-NOT: {{^ [a-z] [0-9][0-9]}}`

due to `addis 10, 2, .LC3 at toc@ha` in the function body.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99870/new/

https://reviews.llvm.org/D99870



More information about the llvm-commits mailing list