[PATCH] D99375: [PowerPC] Add ROP Protection Instructions for PowerPC

[Amy Kwan via Phabricator via llvm-commits]

amyk accepted this revision as: amyk.
amyk added a comment.
This revision is now accepted and ready to land.

Overall this LGTM.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:1536
+// These instructions check a hash computed from the value of the link register
+// and the value of the stack pointer. The instruction may TRAP if the hash does
+// not match the hash stored at the specified address.
----------------
I believe the `hasSideEffects` is needed because the instruction may TRAP if the hash does not match the hash stored at the specified address. This is a super minor nit, but maybe it might be better to explicitly say that the flag is needed because of this reason.
> The hasSideEffects flag is needed as the instruction may TRAP if ...
I think this is minor though, so if you think it's not needed, you can feel free to disregard this comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99375/new/

https://reviews.llvm.org/D99375