[PATCH] D99812: [PowerPC] [GlobalISel] Implementation of formal arguments lowering in the IRTranslator for the PPC backend

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

It would be nicer to have all of these argument tests together in one file, and use update_mir_test_checks



================
Comment at: llvm/lib/Target/PowerPC/GISel/PPCCallLowering.cpp:81-82
+  // initialize instruction writer
+  if (!MBB.empty())
+    MIRBuilder.setInstr(*MBB.begin());
+
----------------
I think this should be setup for you on entry


================
Comment at: llvm/test/CodeGen/PowerPC/GlobalISel/irtranslator-array-arg.ll:3-10
+; CHECK: name: foo
+; CHECK: COPY
+; CHECK: G_TRUNC
+; CHECK: COPY
+; CHECK: G_TRUNC
+; CHECK: COPY
+; CHECK: G_TRUNC
----------------
Should probably just use update_mir_test_checks here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99812/new/

https://reviews.llvm.org/D99812