[PATCH] D99787: [CSSPGO] Fix incorrect probe distribution factor computation in top-down inliner
    Hongtao Yu via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Apr  5 11:05:08 PDT 2021
    
    
  
hoy added inline comments.
================
Comment at: llvm/test/Transforms/SampleProfile/pseudo-probe-icp-factor.ll:248
+
+; CHECK: ![[#]] = !DILexicalBlockFile(scope: ![[#]], file: ![[#]], discriminator: 69206039)
----------------
Thanks for adding the test.
Can you comment here how to interpret the discriminator? Can you also add a check for which call instruction this metadata is attached to? An example could be test/Transforms/SampleProfile/pseudo-probe-profile.ll
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99787/new/
https://reviews.llvm.org/D99787
    
    
More information about the llvm-commits
mailing list